fish_completions: fix completion for macos#1710
Merged
casey merged 4 commits intocasey:masterfrom Oct 30, 2023
l4zygreed:fix/fish_completions
Merged
fish_completions: fix completion for macos#1710casey merged 4 commits intocasey:masterfrom l4zygreed:fix/fish_completions
casey merged 4 commits intocasey:masterfrom
l4zygreed:fix/fish_completions
Conversation
l4zygreed
changed the title
Owner
|
This looks good to me! I'm not a fish user, so if anyone who uses fish wants to try this out before I merge, please do! Otherwise I'll just let it sit for a little bit and merge it. |
|
I can confirm it works on macos 14.1 with fish 3.6.1 |
|
This change is working for me on macOS 13.5 & fish 3.6.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tried to fix broken completion for macos #1703
edited
src/completions.rsfile and regenerated completions viabin/generate-completionsscripttested on macos sonoma and archlinux machine, works the same
replaced
sedwithawkto have more flexible formatting on arguments (and because macossedhave differences)